fix(supabase_flutter): Safely check if conn is not null to avoid null check operator #1178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
After app changes its life cycle,
onResumed()method is called to resume any open web socket connection. This code is executedSo, if the
SocketStatesisdisconnectingit will try to userealtime.conn!assuming is notnullwhen it can benull, hence throwing an error Null check operator used on a null valueIf we look inside
RealtimeClientwhich holdsconnandconnStatewe can see the only timeconnis set tonulland the only timeconnStateis set toSocketStates.disconnectionis here, in thedisconnectmethodso it is clear that
conncan benullandconnStateisdisconnectingwhenoldStateisclosed,disconnectingordisconnectedFixes #1176
What is the new behavior?
The new behavior just checks if
connis notnull.